[Exporter.Geneva] Add named options support for GenevaTraceExporter and GenevaMetricExporter #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
added
the
comp:exporter.geneva
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
reyang and
Yun-Ting
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1218 +/- ##
==========================================
+ Coverage 73.17% 74.07% +0.90%
==========================================
Files 260 265 +5
Lines 9133 9347 +214
==========================================
+ Hits 6683 6924 +241
+ Misses 2450 2423 -27
|
CodeBlanch
reviewed
Jun 5, 2023
|
|
||
| if (configure != null) | ||
| { | ||
| builder.ConfigureServices(services => services.Configure(name, configure)); |
There was a problem hiding this comment.
FYI this will work fine today for metrics & traces because they have different options classes. Logging appears to be sharing GenevaExporterOptions with tracing so if/when logging gets hooked up to DI/options there will be issues with the delegates potentially clobbering each other. Cross that bridge when we come to it 😄
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GenevaTraceExporterandGenevaMetricExporterAddGenevaMetricExporterwithout any parameters to avoid warning RS0026Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes